feat: add ajv-keywords as devDependency#5728
Merged
hyperupcall merged 2 commits intoJun 1, 2026
Merged
Conversation
Required for uniqueItemProperties keyword support in schema validation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
ya7010
added a commit
to ya7010/schemastore
that referenced
this pull request
May 24, 2026
… and examples in JSON schema (SchemaStore#5728)
Contributor
|
@hyperupcall thoughts? |
Contributor
Author
|
@hyperupcall Do chime in when you get the chance! |
All other ajv-related packages (ajv, ajv-draft-04, ajv-formats) live in devDependencies — ajv-keywords belongs there too. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Fixed an anti-pattern: |
miteshashar
changed the title
miteshashar
changed the title
Member
|
Thanks, LGTM! |
Contributor
|
Sorry @hyperupcall, this PR isn't open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ajv-keywordstodevDependenciesinpackage.jsonuniqueItemPropertieskeyword into the AJV factory incli.jspackage-lock.jsonupdated accordinglyWhy
ajv-keywordswas previously only a transitive peer dep. Schemas usinguniqueItemProperties(e.g.claude-code-keybindings.json) fail validation without it being explicitly registered. As a build/test-only tool, it belongs indevDependencies.Dependents
uniqueItemPropertiesinclaude-code-keybindings.jsonand requires this keyword to be available at validation time.🤖 Generated with Claude Code